Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GORM to v2 #9859

Closed
chensun opened this issue Aug 14, 2023 · 1 comment
Closed

Upgrade GORM to v2 #9859

chensun opened this issue Aug 14, 2023 · 1 comment

Comments

@chensun
Copy link
Member

chensun commented Aug 14, 2023

No description provided.

@chensun chensun mentioned this issue Aug 14, 2023
Open
29 tasks
@Linchin
Copy link
Contributor

Linchin commented Aug 23, 2023

After some investigation, it feels like this is a colossal change that's impossible to break down. It also involves lots of trivial changes, such as change of function signatures, variable fields, and some functionalities no longer supported. There's a really good summary by another googler on the work items: google/exposure-notifications-verification-server#857
Since this upgrade does not block PostgreSQL support, after some discussion we decided to stay with GORM v1.

@Linchin Linchin closed this as completed Aug 23, 2023
@Linchin Linchin mentioned this issue Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chensun @Linchin