feat(sdk): add default schema_version to pipeline #6366
Conversation
ji-yaqi
requested review from
neuromage and
chensun
and removed request for
neuromage
sdk/python/kfp/dsl/type_utils.py
Outdated
| @@ -91,7 +91,7 @@ def get_artifact_type_schema( | |||
| artifact_class = artifact_class_or_type_name | |||
|
|
|||
| return pipeline_spec_pb2.ArtifactTypeSchema( | |||
| schema_title=artifact_class.TYPE_NAME) | |||
| schema_title=artifact_class.TYPE_NAME, schema_version="0.0.1") | |||
There was a problem hiding this comment.
Maybe we can add VERSION field to artifacts, and let each artifact separately manage their schema versions. Then this line can be
return pipeline_spec_pb2.ArtifactTypeSchema(
schema_title=artifact_class.TYPE_NAME, schema_version=artifact_class.VERSION)WDYT?
| @@ -7,6 +7,7 @@ | |||
| package pipelinespec | |||
|
|
|||
| import ( | |||
| status "google.golang.org/genproto/googleapis/rpc/status" | |||
There was a problem hiding this comment.
Shall we update this file to register the new changes in pipelineSpec? Maybe we can do it in another PR.
ji-yaqi
force-pushed
the
schema_version
branch
from
621f27a to
61f8c8f
Compare
ji-yaqi
force-pushed
the
schema_version
branch
from
13dd8e7 to
0e3f290
Compare
|
v2-samples tests are blocked by PipelineSpec update. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ji-yaqi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Default to 0.0.1