Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Warn on container component without command. Fixes #4800 #6335

Merged
merged 2 commits into from
Aug 14, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Aug 13, 2021

Description of your changes:
Only yaml component may not have command, so warn during component loading.
Fixes #4800

Checklist:

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you for the quick fix!

sdk/python/kfp/components/_components.py Outdated Show resolved Hide resolved
sdk/python/kfp/components/_components.py Outdated Show resolved Hide resolved
@ji-yaqi
Copy link
Contributor

ji-yaqi commented Aug 14, 2021

/lgtm

@chensun
Copy link
Member Author

chensun commented Aug 14, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 50f7dcd into kubeflow:master Aug 14, 2021
@chensun chensun deleted the warn-on-missing-command branch August 14, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK - Components - Warn when container component does not specify command
4 participants