fix(sdk): Fix compiler bug for legacy outputs mlpipeline-ui-metadata and mlpipeline-metrics. Fixes #6311

[neuromage]

Fixes the bug introduced by PR #6268

Fixes #6311

[neuromage]

/assign @chensun

[Bobgy]

/lgtm

[Bobgy]

I think we have this transform in many places, shall we extract a common util?

[neuromage]

I think that's what I just did here? :-)

[Bobgy]

what's the difference between this and

pipelines/sdk/python/kfp/compiler/_k8s_helper.py

Line 20 in e7c281b

def sanitize_k8s_name(name, allow_capital_underscore=False):

?

[Bobgy]

and

• pipelines/sdk/python/kfp/components/_naming.py

  Lines 51 to 53 in cc83e10

  	def _sanitize_file_name(name):
  	import re
  	return re.sub('[^-_.0-9a-zA-Z]+', '_', name)

• pipelines/sdk/python/kfp/dsl/_pipeline_param.py

  Lines 25 to 41 in cc83e10

  	def sanitize_k8s_name(name, allow_capital_underscore=False):
  	"""Cleans and converts the names in the workflow.
  	Args:
  	name: original name,
  	allow_capital_underscore: whether to allow capital letter and underscore in
  	this name.
  	Returns:
  	A sanitized name.
  	"""
  	if allow_capital_underscore:
  	return re.sub('-+', '-', re.sub('[^-_0-9A-Za-z]+', '-',
  	name)).lstrip('-').rstrip('-')
  	else:
  	return re.sub('-+', '-', re.sub('[^-0-9a-z]+', '-',
  	name.lower())).lstrip('-').rstrip('-')

• pipelines/sdk/python/kfp/dsl/dsl_utils.py

  Lines 51 to 58 in fdab2e6

  	def _sanitize_name(name: str) -> str:
  	"""Sanitizes name to comply with IR naming convention.
  	The sanitized name contains only lower case alphanumeric characters and
  	dashes.
  	"""
  	return re.sub('-+', '-', re.sub('[^-0-9a-z]+', '-',
  	name.lower())).lstrip('-').rstrip('-')

looks like there's an implementation everywhere...

this is a non blocker for this PR

[neuromage]

Sorry, I don't see your point here. These different functions are used in different places. I don't think the goal of this PR is to refactor and clean up this code.

[Bobgy]

Thank you for fixing this quickly!

[Bobgy]

/lgtm

[Bobgy]

/approve
let's get the fix in first

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• sdk/OWNERS [Bobgy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment