From 2b30622901c4edba394f25c617e158cfc74dd366 Mon Sep 17 00:00:00 2001 From: scottxu Date: Fri, 8 Jul 2022 16:11:21 -0700 Subject: [PATCH] resolve comments on docstring and testing --- sdk/python/kfp/client/client.py | 3 --- sdk/python/kfp/client/client_test.py | 21 --------------------- 2 files changed, 24 deletions(-) diff --git a/sdk/python/kfp/client/client.py b/sdk/python/kfp/client/client.py index 5b4986785ce..c30eb7f8f46 100644 --- a/sdk/python/kfp/client/client.py +++ b/sdk/python/kfp/client/client.py @@ -696,9 +696,6 @@ def _override_caching_options(self, pipeline_obj: dict, Args: pipeline_obj (dict): Dict object parsed from the yaml file. enable_caching (bool): Overrides options, one of 'True', 'False'. - - Returns: - None """ for _, task in pipeline_obj['root']['dag']['tasks'].items(): if 'cachingOptions' in task: diff --git a/sdk/python/kfp/client/client_test.py b/sdk/python/kfp/client/client_test.py index caf20485859..0c72c7758d6 100644 --- a/sdk/python/kfp/client/client_test.py +++ b/sdk/python/kfp/client/client_test.py @@ -47,29 +47,8 @@ def test_invalid(self, name: str): client.validate_pipeline_resource_name(name) -PIPELINES_TEST_DATA_DIR = os.path.join( - os.path.abspath(os.path.join(__file__, os.path.pardir, os.path.pardir)), - 'compiler', 'test_data', 'pipelines') - - class TestOverrideCachingOptions(parameterized.TestCase): - @parameterized.parameters([ - 'pipeline_with_importer', - 'pipeline_with_after', - 'pipeline_with_nested_conditions', - 'pipeline_with_loops', - ]) - def test_override_caching_from_yaml(self, pipeline_base_name: str): - pipeline_path = os.path.join(PIPELINES_TEST_DATA_DIR, - f'{pipeline_base_name}.yaml') - with open(pipeline_path) as f: - yaml_dict = yaml.safe_load(f) - test_client = client.Client(namespace='dummy_namespace') - test_client._override_caching_options(yaml_dict, False) - for _, task in yaml_dict['root']['dag']['tasks'].items(): - self.assertFalse(task['cachingOptions']['enableCache']) - def test_override_caching_from_pipeline(self): @component