Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

[Frontend] Standardize code style using prettier #141

Open
4 tasks
kwasi opened this issue Oct 25, 2019 · 3 comments
Open
4 tasks

[Frontend] Standardize code style using prettier #141

kwasi opened this issue Oct 25, 2019 · 3 comments

Comments

@kwasi
Copy link
Contributor

kwasi commented Oct 25, 2019

A kubeflow/metadata version of kubeflow/pipelines issue #2406.

As mentioned in that issue, Prettier will save formatting cycles in code review. It can also be setup with a file watcher to auto-format changed lines or files on save.

Sub-tasks

  • Create a Prettier config
  • Allow a week for comments on the config
  • Format the whole code base after syncing with people with PRs in flight
  • Add a section on code style to frontend/README.md

The last sub-task is blocked by updating the README.md file (#140).

@Bobgy
Copy link
Contributor

Bobgy commented Oct 29, 2019

Thanks for putting these together!

For sync with kubeflow/pipelines. I recommend we use the same config as https://github.com/kubeflow/pipelines/blob/master/frontend/.prettierrc.yaml

trailingComma: all
singleQuote: true
jsxSingleQuote: true
printWidth: 100

Let me know if there's anything you want to change. We can discuss and adjust the config back to kubeflow/pipelines too.

@kwasi
Copy link
Contributor Author

kwasi commented Nov 2, 2019

Sounds good! We definitely want to keep all the frontend projects in sync so we'll start with your .prettierrc.yaml.

@jtfogarty
Copy link

/area front-end
/kind feature
/priority p2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants