K8s 1.25 and Manifests WG

[kimwnasptd]

Tracking issue for all updates that we have to do in the common components of manifests to work with K8s 1.25. With a quick look we took with @apo-ger the biggest item is the deprecation of the policy/v1beta1 API version, and the object that affects most of the components is PodDisruptionBudget

This is a draft plan of the common components and the target versions:

Status	Component	Proposed Version	Context/PRs
✅	Istio	v1.16	#2327
✅	Knative	v1.8	#2325 (comment) https://github.com/knative/community/blob/main/mechanics/RELEASE-SCHEDULE.md#upcoming-releases
✅	Cert Manager	v1.10	#2330

I'll also update the issue further with other changes we'll need to do for K8s 1.25

cc @kubeflow/wg-manifests-leads

[apo-ger]

The generated manifests of Istio v1.6.0 include some policy/v1 PodDisruptionBudget resources that we need to remove. (see istio/istio#12602 and istio/istio#24000)

Until now we have used two patches to address this:

• common/istio-1-16/istio-install/base/patches/remove-pdb.yaml
• common/istio-1-16/cluster-local-gateway/base/patches/remove-pdb.yaml

We found that these patches do not work with kustomize v3.2.0. The problem is that kustomize v3.2.0 doesn't have the appropriate openapi schemas for the policy/v1 API version resources:

• "$patch: delete" not working as expected kubernetes-sigs/kustomize#4495

This is fixed in kustomize v4+:

• [Question] Status of $patch (Strategic Merge Patch) support for Custom Resources kubernetes-sigs/kustomize#3694 (comment)

To resolve this, I've sent a PR with the following changes:

• Upgrade Istio to 1.16.0 to work with K8s 1.25
• Disable the currently used patches until we upgrade to kustomize v4+.
  • tracked in: Upgrade to use Kustomize v4+ #1797
• Introduce a temporary workaround to remove PodDisruptionBudget resources
  manually with yq before deploying Istio manifests.
• Update README file with instructions.

I've also sent another PR to update the KinD cluster version to K8s 1.25 for testing.

[kimwnasptd]

@yuzisun which Knative version should we target for the KF 1.7 release?

Our target K8s version is 1.25, so we'll need a Knative version that works both with that K8s version as well as the KServe version we'll include in KF 1.7

[yuzisun]

@yuzisun which Knative version should we target for the KF 1.7 release?

Our target K8s version is 1.25, so we'll need a Knative version that works both with that K8s version as well as the KServe version we'll include in KF 1.7

@kimwnasptd Let's target to Knative 1.8 though there is an issue I opened which affects KServe and we will need a patched release after Knative fixes the issue.

[apo-ger]

I've prepared a PR to upgrade cert-manager to latest version (v1.10.1)

[apo-ger]

Here is the PR for upgrading knative-eventing to v1.8.1

[kimwnasptd]

Now that the KServe PRs are merged, we are good to go for K8s 1.25 regarding the common components maintained in this repo

/close

[google-oss-prow]

@kimwnasptd: Closing this issue.

In response to this:

Now that the KServe PRs are merged, we are good to go for K8s 1.25 regarding the common components maintained in this repo

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.