Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate image builds of Jupyter UI #2578

Closed
kimwnasptd opened this issue Feb 28, 2019 · 5 comments · Fixed by #2671
Closed

Automate image builds of Jupyter UI #2578

kimwnasptd opened this issue Feb 28, 2019 · 5 comments · Fixed by #2671
Assignees

Comments

@kimwnasptd
Copy link
Member

We need to update the jupyter-web-app's image in gcr to include the changes made in this PR, in order to redirect to the correct URL for the notebook.

@jlewi
Copy link
Contributor

jlewi commented Feb 28, 2019

@kimwnasptd Are we not building and pushing the jupyter image on postsubmit?

@jlewi jlewi added cuj/build-train-deploy area/jupyter Issues related to Jupyter labels Feb 28, 2019
@kimwnasptd
Copy link
Member Author

By taking a look here the image was build only twice including the one done by hand (I guess?) yesterday.
My mentioned PR changed two .js files in the components/jupyter-web-app dir. Is there a process/mechanism looking for changes under the components dir that builds the new images automatically?

@jlewi
Copy link
Contributor

jlewi commented Mar 4, 2019

We should define an E2E test that builds the image automatically.

Some instructions here
https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md#image-auto-release

On presubmit the image should be pushed to gcr.io/kubeflow-ci.
On postsubmt the image should be pushed to gcr.io/kubeflow-images-public

I would suggest using GCB to build the images (that seems to work better than using Docker in Docker or Kaniko).

The mnist jsonnet workflow might be a good place to start.
https://github.com/kubeflow/examples/blob/master/test/workflows/components/mnist.jsonnet

We probably just need the steps to checkout the repos and build the image using GCB.

@kimwnasptd
Copy link
Member Author

/assign @kimwnasptd

@jlewi
Copy link
Contributor

jlewi commented Mar 10, 2019

@kimwnasptd I believe we updated the notebook manager image. Is this issue now tracking automating builds of the notebook manager UI? If so should we update the title to reflect that?

@kimwnasptd kimwnasptd changed the title Update jupyter-web-app Image in gcr Automate image builds of Jupyter UI Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants