-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate image builds of Jupyter UI #2578
Comments
@kimwnasptd Are we not building and pushing the jupyter image on postsubmit? |
By taking a look here the image was build only twice including the one done by hand (I guess?) yesterday. |
We should define an E2E test that builds the image automatically. Some instructions here On presubmit the image should be pushed to gcr.io/kubeflow-ci. I would suggest using GCB to build the images (that seems to work better than using Docker in Docker or Kaniko). The mnist jsonnet workflow might be a good place to start. We probably just need the steps to checkout the repos and build the image using GCB. |
/assign @kimwnasptd |
@kimwnasptd I believe we updated the notebook manager image. Is this issue now tracking automating builds of the notebook manager UI? If so should we update the title to reflect that? |
We need to update the jupyter-web-app's image in gcr to include the changes made in this PR, in order to redirect to the correct URL for the notebook.
The text was updated successfully, but these errors were encountered: