GCP secrets are not created unless oAuth credentials are provided

[daniel-sanche]

I noticed the code to create GCP service account secrets comes after a line that checks for oAuth environment variables. This seems unnecessary, because everything works fine if I provide fake values for the oAuth id and secret. Was this intentional?

This is likely causing people to run into issues like #1949 and #1950 which are hard to diagnose without looking at the code

[texasmichelle]

+1 to creating service accounts even when IAP is skipped

[daniel-sanche]

Opened PR here: #2313

[jlewi]

@dansanche Can we close this issue? Does this warrant a cherry-pick onto the 0.4 branch?

[daniel-sanche]

Yes, sorry this is good to close. I opened and merged a 0.4 cherry-pick PR here: #2324