You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One thing comes to mind: I noticed that _write_workflow has the ability to simply return the yaml in-memory:
ifpackage_pathisNone:
returnyaml_text
However, _create_and_write_workflow doesn't propagate that, as it doesn't return the _write_workflow's result. In the original KFP it wasn't a real issue, as the implementation of _create_and_write_workflow was as simple as:
so one could simply use _create_workflow if really needed. It's to as easy for kfp-tekton, _create_and_write_workflow being 60 lines.
Considering how compile is based on Argo KFP's version, it probably cannot be changed that way, but maybe another method that would return a yaml (or maybe a list of yamls, considering the possibility of multiple resources?) in-memory could be added? That could possibly result in an even bigger speed-up for some cases.
@Tomcli
One thing comes to mind: I noticed that
_write_workflow
has the ability to simply return the yaml in-memory:However,
_create_and_write_workflow
doesn't propagate that, as it doesn't return the_write_workflow
's result. In the original KFP it wasn't a real issue, as the implementation of_create_and_write_workflow
was as simple as:so one could simply use
_create_workflow
if really needed. It's to as easy for kfp-tekton,_create_and_write_workflow
being 60 lines.Considering how
compile
is based on Argo KFP's version, it probably cannot be changed that way, but maybe another method that would return a yaml (or maybe a list of yamls, considering the possibility of multiple resources?) in-memory could be added? That could possibly result in an even bigger speed-up for some cases.Originally posted by @Udiknedormin in #736 (comment)
We want to have a new method to return the workflow dictionary in Python memory to optimize the API response time when running the SDK as a service.
The text was updated successfully, but these errors were encountered: