-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSOC] Support for various Parameter distributions in Katib #2334
[GSOC] Support for various Parameter distributions in Katib #2334
Conversation
Hey @tenzen-y |
Based on recent discussions, we decided to keep the v1beta1 API version, and then we will add parameter distribution API to the v1beta1 API. That would be great to collect early feedback from users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
I added a few comments.
/assign @tenzen-y @johnugeorge
b22418d
to
42f1e14
Compare
/area gsoc |
c7d9036
to
d853fa5
Compare
/assign |
db3526c
to
485cf0a
Compare
485cf0a
to
d6b8838
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments.
5794f01
to
3c9deb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment for a nit.
Otherwise lgtm.
Signed-off-by: Shashank Mittal <[email protected]> modified feasibleSpace refactored proposal based on comments comparison table updated extra heading removed
a34c3b0
to
d3b1f8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2059
Checklist: