Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ModuleNotFoundError: No module named 'kubeflow.katib.katib_api_pb2'
setup.py
we're copying a file frompkg/
directory tokubeflow/katib
directory which we don't check in into github. https://github.com/kubeflow/katib/blob/master/sdk/python/v1beta1/setup.py#L29-L36katib_api_pb2.py
was present in.gitingore
, it was not highlighted in my ide/terminal and somehow I missed it in my local testing. https://github.com/kubeflow/katib/blob/master/sdk/python/v1beta1/.gitignore#L5Checklist: