Job level webhook for metrics collector sidecar container

[hougangliu]

/kind feature
/P2
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
for now, we inject metrics collector sidecar container in Pod webhook, we can consider metrics collector sidecar container in Job webhook level for performance.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

[johnugeorge]

/priority p2

[johnugeorge]

This is no more required in k8s 1.15 as we could use more efficient object selector in web hooks

[vpavlin]

This could actually solve #963 as it would reorder actions - first add the container in the Job and then let a job controller generate the pod, so it makes sense form my point of view:)

[hougangliu]

This could actually solve #963 as it would reorder actions - first add the container in the Job and then let a job controller generate the pod, so it makes sense form my point of view:)

@vpavlin yes, it can solve #963, but it is low priority as plan and will be included in Kubeflow 1.0 release. As #964 (comment), I think #963 is a very common issue for openshift, we should solve it in a common way.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.