Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need validate nasConfig #372

Closed
hougangliu opened this issue Feb 13, 2019 · 6 comments
Closed

need validate nasConfig #372

hougangliu opened this issue Feb 13, 2019 · 6 comments
Assignees
Labels

Comments

@hougangliu
Copy link
Member

Now for a studyjob, we never check if a nasConfig is valid or not.
#339 is nasrl suggestion service, which always expects graphConfig (numlayers, input size,outputsize) and operations field present. we need validate nasconfig filed before store studyjob info into db.

@andreyvelich WDYT?

@hougangliu
Copy link
Member Author

/cc @DeeperMind

@andreyvelich
Copy link
Member

@hougangliu
This is a good point!
Do you think, we should check it in the controller step?
For example, if something wrong with nasConfig structure, studyJob status should be Failed and controller should stop the job?

@andreyvelich
Copy link
Member

/area nas

@johnugeorge
Copy link
Member

See validateStudy in

if validErr := validateStudy(instance, ns); validErr != nil {

@andreyvelich
Copy link
Member

@johnugeorge
Thats cool!
Should I add a part there for the NAS job ?

@andreyvelich
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants