Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Feature] Expose the underlying Suggestion #1439

Open
andreyvelich opened this issue Feb 18, 2021 · 6 comments
Open

[UI Feature] Expose the underlying Suggestion #1439

andreyvelich opened this issue Feb 18, 2021 · 6 comments

Comments

@andreyvelich
Copy link
Member

/kind feature

The new Katib UI should show the YAML for the Experiment's Suggestion.

One solution can be:

  1. Rename YAML tab to Experiment YAML
  2. Add new tab Suggestion YAML and show Suggestion info there.

Later we can add another tab to monitor Suggestion logs.
Add Suggestion Conditions under Experiment Conditions in the Overview tab.

@andreyvelich
Copy link
Member Author

/cc @kimwnasptd

@kimwnasptd
Copy link
Member

@andreyvelich let's rename this issue to [UI Feature] Expose the underlying Suggestion or something similar, since we will be discussing our approach of how to show the underlying Suggestion CR in many different places.

Add Suggestion Conditions under Experiment Conditions in the Overview tab.

This grouping makes sense. The UI effort is non-trivial, but we will need to slightly extend the backend to expose the owned Suggestion CR

Later we can add another tab to monitor Suggestion logs.

Agree, although we will need to also extend the backend to export these logs

The new Katib UI should show the YAML for the Experiment's Suggestion.
One solution can be:

  1. Rename YAML tab to Experiment YAML
  2. Add new tab Suggestion YAML and show Suggestion info there.

I think I'd prefer to keep the YAML tab and have a switching mechanism underneath, like some radio buttons (?). I'd like to create some iterations with both cases so we can see how they look and then decide on which road to follow.

@andreyvelich andreyvelich changed the title [UI Feature] Expose the YAML for the underlying Suggestion [UI Feature] Expose the underlying Suggestion Feb 19, 2021
@andreyvelich
Copy link
Member Author

andreyvelich commented Feb 19, 2021

but we will need to slightly extend the backend to expose the owned Suggestion CR

I believe the backend already has fetch_suggestion API which returns Suggestion CR: https://github.com/kubeflow/katib/blob/master/pkg/ui/v1beta1/backend.go#L326.

Agree, although we will need to also extend the backend to export these logs

That's right. Currently, we haven't decided how to receive Suggestion and Trials log from the backend.

I think I'd prefer to keep the YAML tab and have a switching mechanism underneath, like some radio buttons (?). I'd like to create some iterations with both cases so we can see how they look and then decide on which road to follow.

I was thinking about the same way with radio buttons and one YAML tab.
This approach decreases number of tabs and simplify UX.

Does it look good if we have separate tab for the Suggestion log or you have any other better places to implement it?

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member Author

/lifecycle frozen

@andreyvelich
Copy link
Member Author

/priority p3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants