From bbdf2828f30c74a35ef935930ba9556a0c33b092 Mon Sep 17 00:00:00 2001 From: Gang Pu Date: Thu, 11 Nov 2021 17:58:42 +0800 Subject: [PATCH] Rollback #172 as it introduce hard requirements for the list values to not be empty (#174) * Change listType to be map for jobstatus condition * rollback the changes to allow empty value for condition --- pkg/apis/common/v1/openapi_generated.go | 5 ----- pkg/apis/common/v1/types.go | 1 - 2 files changed, 6 deletions(-) diff --git a/pkg/apis/common/v1/openapi_generated.go b/pkg/apis/common/v1/openapi_generated.go index 9e986b84..3a9cf462 100644 --- a/pkg/apis/common/v1/openapi_generated.go +++ b/pkg/apis/common/v1/openapi_generated.go @@ -364,11 +364,6 @@ func schema_pkg_apis_common_v1_JobStatus(ref common.ReferenceCallback) common.Op Type: []string{"object"}, Properties: map[string]spec.Schema{ "conditions": { - VendorExtensible: spec.VendorExtensible{ - Extensions: spec.Extensions{ - "x-kubernetes-list-type": "set", - }, - }, SchemaProps: spec.SchemaProps{ Description: "Conditions is an array of current observed job conditions.", Type: []string{"array"}, diff --git a/pkg/apis/common/v1/types.go b/pkg/apis/common/v1/types.go index 512842f5..0b894b26 100644 --- a/pkg/apis/common/v1/types.go +++ b/pkg/apis/common/v1/types.go @@ -22,7 +22,6 @@ import ( // +k8s:deepcopy-gen=true // JobStatus represents the current observed state of the training Job. type JobStatus struct { - // +listType=set // Conditions is an array of current observed job conditions. Conditions []JobCondition `json:"conditions"`