Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] compatibility problem with tf-operator v1.0.1 #498

Open
gaocegege opened this issue Mar 12, 2021 · 4 comments
Open

[chore] compatibility problem with tf-operator v1.0.1 #498

gaocegege opened this issue Mar 12, 2021 · 4 comments
Assignees
@happy2048

Comments

@gaocegege
Copy link
Member

kubeflow/training-operator@984adc2#diff-c3cd90fce520caf42f3e75efbc527abd0d119271103de3fe6f0168e8c5fb8c33L30

Kubeflow/common unifies the label for all jobs, while we are still using tf-replica-type in arena. Should we update to replica-type?

cc @cheyang
@gaocegege
Copy link
Member Author

cc @happy2048

@happy2048
Copy link
Contributor

we have using https://github.com/AliyunContainerService/tf-operator/tree/v1.0-aliyun-branch to build tf-operator for arena, this branch includes some custom features different from kubeflow/tf-operator.

@gaocegege
Copy link
Member Author

Can we merge the change AliyunContainerService/tf-operator@61b5919 to the mainstream?

@happy2048
Copy link
Contributor

Can we merge the change AliyunContainerService/tf-operator@61b5919 to the mainstream?

ok, I will commit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@happy2048 happy2048

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaocegege @happy2048