deny.toml stricten unknown sources + bump tokio for rustsec issue #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ID: RUSTSEC-2021-0124
= Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0124
= If a `tokio::sync::oneshot` channel is closed (via the
[`oneshot::Receiver::close`] method), a data race may occur if the
`oneshot::Sender::send` method is called while the corresponding
`oneshot::Receiver` is `await`ed or calling `try_recv`.
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
|
was trying to figure out why it didn't trigger on CI, and it was because it only showed up locally because my local lockfile had set tokio to 0.12. so this isn't actually an issue that we need to rush a release out for, users can pin a newer version of tokio to fix this themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found a rustsec issue running cargo deny check manually. came out a few days ago. https://rustsec.org/advisories/RUSTSEC-2021-0124. it looks like it applies to us since we use
oneshotin the controller. description from discord:we use it only once (excluding tests) in the
graceful_shutdown channel, and those channels only close when we close the whole app, but memory corruption - even at that point - could be bad.