Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump secrecy to 0.10 #1588

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Bump secrecy to 0.10 #1588

merged 4 commits into from
Sep 24, 2024

Conversation

clux
Copy link
Member

@clux clux commented Sep 23, 2024

Updates secrecy manually, replacing dependabot pr #1586 by removing now default hard features, and fixes to breaking changes.

changes noted from https://github.com/iqlusioninc/crates/blob/main/secrecy/CHANGELOG.md#0100-2024-09-17

SecretString internals is now a SecretBox, and this needs an .into() call to convert to a Box<S>.
See https://docs.rs/secrecy/0.10.2/secrecy/type.SecretString.html

This brings with it a small breaking change to the disk configuration format (since we export types containing the secrecy types).

replaces #1586 by removing now default hard features, and fixes to breaking changes.
changes noted from https://github.com/iqlusioninc/crates/blob/main/secrecy/CHANGELOG.md#0100-2024-09-17

the only part here is SecretString internals is now a SecretBox,
and this needs an into() call to convert to a Box<S>

See https://docs.rs/secrecy/0.10.2/secrecy/type.SecretString.html

Signed-off-by: clux <[email protected]>
@clux clux added dependencies upgrades to dependencies changelog-change changelog change category for prs labels Sep 23, 2024
@clux clux added this to the 0.96.0 milestone Sep 23, 2024
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.3%. Comparing base (0fa32b8) to head (cf01c21).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-client/src/client/auth/oidc.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1588     +/-   ##
=======================================
- Coverage   75.3%   75.3%   -0.0%     
=======================================
  Files         82      82             
  Lines       7329    7327      -2     
=======================================
- Hits        5517    5515      -2     
  Misses      1812    1812             
Files with missing lines Coverage Δ
kube-client/src/client/auth/mod.rs 48.9% <100.0%> (ø)
kube-client/src/config/file_config.rs 74.2% <100.0%> (-0.2%) ⬇️
kube-client/src/client/auth/oidc.rs 56.5% <0.0%> (ø)

@clux clux marked this pull request as ready for review September 23, 2024 13:33
@clux clux changed the title Bump secrecy to 0.10 Bump secrecy to 0.10 Sep 24, 2024
@clux clux merged commit acd2d8e into main Sep 24, 2024
18 checks passed
@clux clux deleted the bump-secrecy branch September 24, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants