Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace watchNamespaces and watchNamespaceSelector by watchNamespaceSelectors #1394

Closed
aslafy-z opened this issue Jul 25, 2023 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@aslafy-z
Copy link
Collaborator

Deprecate watchNamespaces and encourage users to use the kubernetes.io/metadata.name label (available since 1.22) to select namespaces by name. watchNamespaceSelectors will be added to support a list of selectors instead of a single selector as watchNamespaceSelector does.

Deprecate watchNamespaces and watchNamespaceSelector and mark for removal for next major.

Originally posted by @aslafy-z in #1392 (comment)

@aslafy-z aslafy-z added the enhancement New feature or request label Jul 25, 2023
@aslafy-z aslafy-z self-assigned this Jul 25, 2023
@pepov
Copy link
Member

pepov commented Jul 25, 2023

As I'm thinking about it more I'm not sure I would like that API better.

As far as I understand the namespace name label was needed to allow selecting specific namespaces for network policies (where there is no other option), but in this case it seems to be an overkill and would unnecessarily complicate the API.

I just don't see the benefit here.

Reference: kubernetes/enhancements#2161

@stale
Copy link

stale bot commented Sep 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the wontfix This will not be worked on label Sep 23, 2023
@stale stale bot closed this as completed Sep 30, 2023
@pepov
Copy link
Member

pepov commented Oct 2, 2023

to be fair, in a new API I would consider the selector-only option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants