-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Vault namespaces #3
Comments
Any update regarding the feature. ? |
@igorcoding Could you let me know whether you could update the controller to support Vault Namespaces? I have a requirement to write secrets generated by Vault on AWS via Dyanamic creds to be written back to Vault. Also read secrets from Vault Namespaces. |
@linuxbsdfreak hi! Sorry for the delay. I'll try to have a look, but can't guarantee any specific ETA right now. Just want to mention, that PRs are always welcome - I'll respond swiftly if you want to contribute. |
Thx @igorcoding no issues. I thought it was a small fix . I will try to look. Could you provide me some pointers under which files I need to add the code ? |
I bet adding some more configuration, like adding a name of namespace to the spec - https://github.com/ktsstudio/mirrors/blob/main/api/v1alpha2/vault.go, and to add logic of supplying this namespace to https://github.com/ktsstudio/mirrors/blob/main/pkg/vaulter/vaulter.go would do the trick |
@igorcoding I was trying to extend the code and saw that https://github.com/ktsstudio/mirrors/blob/main/pkg/vaulter/vaulter.go#L15 The DefaultConfig does not have a Namespace is the struct to work with https://github.com/hashicorp/vault/blob/main/api/client.go#L96 |
Hi! I believe the Client's method WithNamespace is needed https://pkg.go.dev/github.com/hashicorp/vault/api#Client.WithNamespace |
This is needed for integration with Vault Enterprise. Should be a fairly simple addition.
The text was updated successfully, but these errors were encountered: