Allow doctype declaration for JaCoCo

src/main/groovy/org/kt3k/gradle/plugin/CoverallsPlugin.groovy

@@ -4,9 +4,6 @@ import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.api.Task
 import org.kt3k.gradle.plugin.coveralls.CoverallsTask
-import org.kt3k.gradle.plugin.coveralls.domain.CoberturaSourceReportFactory
-import org.kt3k.gradle.plugin.coveralls.domain.JacocoSourceReportFactory
-import org.kt3k.gradle.plugin.coveralls.domain.SourceReportFactory
 
 /**
  * Coveralls plugin for gradle.

src/main/groovy/org/kt3k/gradle/plugin/coveralls/domain/CoberturaSourceReportFactory.groovy

@@ -11,16 +11,7 @@ class CoberturaSourceReportFactory implements SourceReportFactory {
 	@Override
 	List<SourceReport> createReportList(Project project, File file) {
 		// create parser
-		XmlParser parser = new XmlParser()
-
-		// skip external DTD validation
-		// see http://xerces.apache.org/xerces2-j/features.html#nonvalidating.load-external-dtd
-		parser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false)
-
-		// allow DOCTYPE declaration
-		// see http://xerces.apache.org/xerces2-j/features.html#disallow-doctype-decl
-		// this is the same as the default, but in some situation it seems to turn to be true ( see https://github.com/kt3k/coveralls-gradle-plugin/pull/16 )
-		parser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false)
+		XmlParser parser = new XmlParserFactory().xmlParser
 
 		// parse
 		Node coverage = parser.parse(file)

src/main/groovy/org/kt3k/gradle/plugin/coveralls/domain/JacocoSourceReportFactory.groovy

@@ -46,11 +46,7 @@ class JacocoSourceReportFactory implements SourceReportFactory {
 
 	static List<SourceReport> createReportList(List<File> srcDirs, File jacocoReportFile) {
 		// create parser
-		XmlParser parser = new XmlParser()
-
-		// skip external DTD validation
-		// see http://xerces.apache.org/xerces2-j/features.html#nonvalidating.load-external-dtd
-		parser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false)
+		XmlParser parser = new XmlParserFactory().xmlParser
 
 		// parse
 		Node report = parser.parse(jacocoReportFile)

src/main/groovy/org/kt3k/gradle/plugin/coveralls/domain/XmlParserFactory.groovy

@@ -0,0 +1,20 @@
+package org.kt3k.gradle.plugin.coveralls.domain
+
+class XmlParserFactory {
+
+  def getXmlParser() {
+    // create parser
+    XmlParser parser = new XmlParser()
+
+    // skip external DTD validation
+    // see http://xerces.apache.org/xerces2-j/features.html#nonvalidating.load-external-dtd
+    parser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false)
+
+    // allow DOCTYPE declaration
+    // see http://xerces.apache.org/xerces2-j/features.html#disallow-doctype-decl
+    // this is the same as the default, but in some situation it seems to turn to be true ( see https://github.com/kt3k/coveralls-gradle-plugin/pull/16 )
+    parser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false)
+
+    return parser
+  }
+}

src/test/groovy/org/kt3k/gradle/plugin/coveralls/CoverallsTaskTest.groovy

@@ -15,7 +15,6 @@ import org.gradle.testfixtures.ProjectBuilder
 
 import org.kt3k.gradle.plugin.CoverallsPluginExtension
 import org.kt3k.gradle.plugin.coveralls.domain.CoberturaSourceReportFactory
-import org.kt3k.gradle.plugin.coveralls.domain.SourceReportFactory
 
 import org.mockito.Mockito
 

src/test/groovy/org/kt3k/gradle/plugin/coveralls/domain/XmlParserFactoryTest.groovy

@@ -0,0 +1,16 @@
+package org.kt3k.gradle.plugin.coveralls.domain
+
+import org.junit.Test
+
+import static org.junit.Assert.assertFalse
+
+class XmlParserFactoryTest {
+
+  @Test
+  void testXmlParserConfiguration() {
+    def parser = new XmlParserFactory().xmlParser
+
+    assertFalse parser.getFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd")
+    assertFalse parser.getFeature("http://apache.org/xml/features/disallow-doctype-decl")
+  }
+}