From 111b3e6b1b9f5507df9b8efb91afbac8c86cef2d Mon Sep 17 00:00:00 2001 From: David Li Date: Tue, 29 Jan 2019 13:44:33 -0500 Subject: [PATCH] Fix style/lint issues --- cpp/src/arrow/flight/client.cc | 2 +- cpp/src/arrow/flight/client.h | 3 ++- cpp/src/arrow/flight/server.h | 5 ++--- integration/integration_test.py | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/cpp/src/arrow/flight/client.cc b/cpp/src/arrow/flight/client.cc index 99f88d08a843e..f748d498e8f22 100644 --- a/cpp/src/arrow/flight/client.cc +++ b/cpp/src/arrow/flight/client.cc @@ -123,7 +123,7 @@ class FlightStreamWriter : public ipc::RecordBatchWriter { : rpc_{std::move(rpc)}, descriptor_{descriptor}, schema_{schema}, - pool_{default_memory_pool()} {}; + pool_{default_memory_pool()} {} Status WriteRecordBatch(const RecordBatch& batch, bool allow_64bit = false) override { IpcPayload payload; diff --git a/cpp/src/arrow/flight/client.h b/cpp/src/arrow/flight/client.h index e548f7c76e848..61c357e561f1b 100644 --- a/cpp/src/arrow/flight/client.h +++ b/cpp/src/arrow/flight/client.h @@ -92,7 +92,7 @@ class ARROW_EXPORT FlightClient { /// \brief Given a flight ticket and schema, request to be sent the /// stream. Returns record batch stream reader - /// \param[in] ticket + /// \param[in] ticket The flight ticket to use /// \param[in] schema the schema of the stream data as computed by /// GetFlightInfo /// \param[out] stream the returned RecordBatchReader @@ -102,6 +102,7 @@ class ARROW_EXPORT FlightClient { /// \brief Upload data to a Flight described by the given descriptor. /// \param[in] descriptor the descriptor of the stream + /// \param[in] schema the schema for the data to upload /// \param[out] stream a writer to write record batches to /// \return Status Status DoPut(const FlightDescriptor& descriptor, const std::shared_ptr& schema, diff --git a/cpp/src/arrow/flight/server.h b/cpp/src/arrow/flight/server.h index f975b8619cd48..b2e8b02be8e7d 100644 --- a/cpp/src/arrow/flight/server.h +++ b/cpp/src/arrow/flight/server.h @@ -69,9 +69,9 @@ class ARROW_EXPORT FlightDataStream { /// \brief A basic implementation of FlightDataStream that will provide /// a sequence of FlightData messages to be written to a gRPC stream -/// \param[in] reader produces a sequence of record batches class ARROW_EXPORT RecordBatchStream : public FlightDataStream { public: + /// \param[in] reader produces a sequence of record batches explicit RecordBatchStream(const std::shared_ptr& reader); std::shared_ptr schema() override; @@ -98,8 +98,7 @@ class ARROW_EXPORT FlightServerBase { /// \brief Run an insecure server on localhost at the indicated port. Block /// until server is shut down or otherwise terminates - /// \param[in] port - /// \return Status + /// \param[in] port the port to bind to void Run(int port); /// \brief Shut down the server. Can be called from signal handler or another diff --git a/integration/integration_test.py b/integration/integration_test.py index fc02d0712006c..e7e8edda6ddf1 100644 --- a/integration/integration_test.py +++ b/integration/integration_test.py @@ -1006,9 +1006,9 @@ def _compare_flight_implementations(self, producer, consumer): with producer.flight_server(): for json_path in self.json_files: - print('==========================================================') + print('=' * 58) print('Testing file {0}'.format(json_path)) - print('==========================================================') + print('=' * 58) # Have the client upload the file, then download and # compare