Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request of merging my branch #11

Open
lvs-sueshin opened this issue May 12, 2016 · 6 comments
Open

Request of merging my branch #11

lvs-sueshin opened this issue May 12, 2016 · 6 comments

Comments

@lvs-sueshin
Copy link

Hi John,

Could you please merge my branch to your master branch?
https://github.com/lvs-shinjisueyoshi/grunt-kss/tree/v2.0.0

This is grunt-kss version 2.0.0, it's great isn't it?
Hope you like it.

Cheers,
Shinji

@RobLoach
Copy link
Contributor

Open up a pull request, and we'll have a look!

@JohnAlbin
Copy link
Contributor

I've merged this into a 2.x branch, since I can't merge it into master.

I can't re-tag 2.0.0 because the commit SHA1 is lost and the old maintainer already published 2.0.0 to NPM.

What would you like to do now?

@lvs-sueshin
Copy link
Author

Thank you!!
I see.

Would you tell me 2.0.0 made by old maintainer?

@JohnAlbin
Copy link
Contributor

Would you tell me 2.0.0 made by old maintainer?

I don't have the old 2.0.0 commit SHA1 in Git. And npm already has a specific SHA1 attached to its published 2.0.0 version. I can't recreate 2.0.0 without access to the old Git repo that the previous maintainer deleted.

I can create a 2.0.1 version off the code you gave. Would you like me to do that?

@lvs-sueshin
Copy link
Author

lvs-sueshin commented Nov 8, 2016

I can create a 2.0.1 version off the code you gave. Would you like me to do that?

You don't have to.
I don't need 2.0.1.
Because I'm looking for 2.0.0 at published npm.
Do you know Where is it?

@lvs-sueshin
Copy link
Author

lvs-sueshin commented Nov 8, 2016

Oh! Sorry!!
I misunderstood.
I'm not good at using English.
I take back what I said.

Would you create a 2.0.1 version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants