Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support IAM Roles for Service Accounts #51

Open
ianonavy opened this issue May 24, 2023 · 3 comments
Open

Feature request: support IAM Roles for Service Accounts #51

ianonavy opened this issue May 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ianonavy
Copy link

Is your feature request related to a problem? If so, please describe.

Currently, the S3 storage provider uses static credentials pulled from Kubernetes config. This works great for on-premise Kubernetes clusters, but for cluster admins running in AWS EKS the preferred method of authenticating to AWS APIs is IAM Roles for Service Accounts (IRSA). The kserve controller added support for IRSA in 2021 for non-ModelMesh InferenceServices; it would be great if we could use IRSA with ModelMesh as well.

Describe your proposed solution

What I would propose is instead of failing early when the access_key_id is missing, simply allow the S3 client to infer credentials from the environment using the default credential provider chain if the creds are missing from the config.

Describe alternatives you have considered

For now we will use static credentials since they are the only option. We also considered using a local minio instance as a proxy to S3 since minio does support IRSA, but we decided that was too complex.

Additional context

For context, see this user guide from AWS.

@ckadner
Copy link
Member

ckadner commented Jan 19, 2024

@ianonavy @mateusz-ciesielski -- if this something you are still interested in, would you want to create a PR for it?

@Radwan-Ibrahim
Copy link

@ckadner Mateusz created a PR for adding this feature to ibm-cos-sdk-go, could you please help him by reviewing his PR?
IBM/ibm-cos-sdk-go#13

@mateusz-ciesielski
Copy link

@ckadner I have a fork with IRSA support working here: mateusz-ciesielski@57f0cd1

But this commit depends on changes in ibm-cos-sdk-go repository, so we would have to merge IBM/ibm-cos-sdk-go#13 first before adding IRSA support to modelmesh-runtime-adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants