Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove whitespaces from file names #1048

Merged
merged 2 commits into from
May 9, 2024
Merged

Remove whitespaces from file names #1048

merged 2 commits into from
May 9, 2024

Conversation

adincebic
Copy link
Contributor

Helps remedy issue with bazel coverage command bazelbuild/bazel#4327

Checklist:

  • Correct file headers (see CONTRIBUTING.md).
  • Formatted with SwiftFormat.
  • Tests added.

Changes proposed in this pull request:

  • Renamed a couple of files such that they no longer contain whitespaces.
  • Whitespaces present an issue when using this library with Bazel build system.
  • This is a minor change for the CryptoSwift but solves many problems for developers on Apple platforms who are using Bazel.

@adincebic adincebic requested a review from krzyzanowskim as a code owner May 3, 2024 10:59
@krzyzanowskim
Copy link
Owner

you have to update Xcode project too, to reference renamed files. please

@adincebic
Copy link
Contributor Author

you have to update Xcode project too, to reference renamed files. please

Done.

@krzyzanowskim krzyzanowskim merged commit fcdd61d into krzyzanowskim:main May 9, 2024
2 checks passed
@krzyzanowskim
Copy link
Owner

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzanowskim krzyzanowskim krzyzanowskim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adincebic @krzyzanowskim