-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable output of version number in generated files header #399
Comments
Hi @danielr I see your point, but from my perspective the version is something that may help eventually, as a reference I see that CocoaPods, for example, also writes version that generated @ilyapuchka @krzysztofzablocki what do you think about it? |
I agree with @Antondomashnev, its helpful to have version there |
@danielr I think we should keep the version number, and I really think it may help your team eventually 😄 |
Agree too, having version is valuable. |
Hi! I understand that versioning can be of use to some people. Is there any chance you reconsider adding an option to make this configurable? |
Hello @dcacenabes , due to the importance of speeding up CI time and improving developer experience, which was rarely the case in the past, Let's reopen and quickly fix 👍🏻 |
Hey @art-divin, if you want to go for removing it, I can contribute with a PR myself if it is ok with you :) |
Hey 👋 Would be greatly appreciated, in fact, just in time before 2.1.9 release! |
I just opened a PR, but I am not sure if I should have edited all the .generated files. Since they were being tracked under source control I decided to update them too. |
For those people who like committing the generated files to version control (yes, I'm aware of the pros and cons), it would be great to have the option to exclude the version number from the header of the generated files. Otherwise every upgrade of Sourcery leads to meaningless changes in the working copy:
I guess this could be either a command line option, or an option in the config file (or both).
I'd be happy to contribute this myself in case it's deemed useful.
The text was updated successfully, but these errors were encountered: