From a9ee941fdf4bc0fff05ca742e8203e984b33cfcd Mon Sep 17 00:00:00 2001 From: "Kirill A. Shutemov" Date: Thu, 25 Feb 2016 13:00:28 +1100 Subject: [PATCH] khugepaged: __collapse_huge_page_swapin(): drop unused 'pte' parameter 'pte' dereference is eliminated by compiler, since nobody uses the pteval until it's overwritten inside the loop. Value of 'pte' itself is overwritten by pte_offset_map() before first real use. Signed-off-by: Kirill A. Shutemov Cc: Ebru Akagunduz Signed-off-by: Andrew Morton --- mm/huge_memory.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 6e1c273773016a..794057aa7ee73c 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2355,11 +2355,10 @@ static bool hugepage_vma_check(struct vm_area_struct *vma) static void __collapse_huge_page_swapin(struct mm_struct *mm, struct vm_area_struct *vma, - unsigned long address, pmd_t *pmd, - pte_t *pte) + unsigned long address, pmd_t *pmd) { unsigned long _address; - pte_t pteval = *pte; + pte_t *pte, pteval; int swapped_in = 0, ret = 0; pte = pte_offset_map(pmd, address); @@ -2454,7 +2453,7 @@ static void collapse_huge_page(struct mm_struct *mm, anon_vma_lock_write(vma->anon_vma); - __collapse_huge_page_swapin(mm, vma, address, pmd, pte); + __collapse_huge_page_swapin(mm, vma, address, pmd); pte = pte_offset_map(pmd, address); pte_ptl = pte_lockptr(mm, pmd);