From 7afe39026614487890305fd5fa31110519445ba8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Krzemi=C5=84ski?= <3110813+krzema12@users.noreply.github.com> Date: Fri, 6 Sep 2024 10:34:27 +0200 Subject: [PATCH 1/3] Do not use custom inputs when calling benchmark action --- .github/workflows/benchmark.main.kts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/benchmark.main.kts b/.github/workflows/benchmark.main.kts index 4d7adfd3c..0e58894ea 100755 --- a/.github/workflows/benchmark.main.kts +++ b/.github/workflows/benchmark.main.kts @@ -150,11 +150,9 @@ workflow( failThreshold = "200%", ghRepository = "github.com/krzema12/snakeyaml-engine-kmp-benchmarks", outputFilePath = AGGREGATED_REPORT, - _customInputs = mapOf( - "github-token" to expr { PUBLISH_BENCHMARK_RESULTS }, - // Push and deploy GitHub pages branch automatically only if run in main repo and not in PR - "auto-push" to expr { "${github.repository} == 'krzema12/snakeyaml-engine-kmp' && ${github.event_name} != 'pull_request'" }, - ) + githubToken = expr { PUBLISH_BENCHMARK_RESULTS }, + // Push and deploy GitHub pages branch automatically only if run in main repo and not in PR + autoPush_Untyped = expr { "${github.repository} == 'krzema12/snakeyaml-engine-kmp' && ${github.event_name}, ), ) } From 39b295707eac6c4e3e01d798cda031aba88d33f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Krzemi=C5=84ski?= <3110813+krzema12@users.noreply.github.com> Date: Fri, 6 Sep 2024 10:37:42 +0200 Subject: [PATCH 2/3] Add missing part of expr --- .github/workflows/benchmark.main.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmark.main.kts b/.github/workflows/benchmark.main.kts index 0e58894ea..01ba503e0 100755 --- a/.github/workflows/benchmark.main.kts +++ b/.github/workflows/benchmark.main.kts @@ -152,7 +152,7 @@ workflow( outputFilePath = AGGREGATED_REPORT, githubToken = expr { PUBLISH_BENCHMARK_RESULTS }, // Push and deploy GitHub pages branch automatically only if run in main repo and not in PR - autoPush_Untyped = expr { "${github.repository} == 'krzema12/snakeyaml-engine-kmp' && ${github.event_name}, + autoPush_Untyped = expr { "${github.repository} == 'krzema12/snakeyaml-engine-kmp' && ${github.event_name} != 'pull_request'" }, ), ) } From ba08922802c378b74c5fbfa81085ff9fa9c42357 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Krzemi=C5=84ski?= <3110813+krzema12@users.noreply.github.com> Date: Fri, 6 Sep 2024 10:42:15 +0200 Subject: [PATCH 3/3] Fix yaml --- .github/workflows/benchmark.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/benchmark.yaml b/.github/workflows/benchmark.yaml index 010a50575..874e8c2cd 100644 --- a/.github/workflows/benchmark.yaml +++ b/.github/workflows/benchmark.yaml @@ -95,9 +95,9 @@ jobs: tool: 'jmh' output-file-path: 'aggregated.json' gh-repository: 'github.com/krzema12/snakeyaml-engine-kmp-benchmarks' + github-token: '${{ secrets.PUBLISH_BENCHMARK_RESULTS }}' + auto-push: '${{ github.repository == ''krzema12/snakeyaml-engine-kmp'' && github.event_name != ''pull_request'' }}' summary-always: 'true' comment-on-alert: 'true' alert-threshold: '150%' fail-threshold: '200%' - github-token: '${{ secrets.PUBLISH_BENCHMARK_RESULTS }}' - auto-push: '${{ github.repository == ''krzema12/snakeyaml-engine-kmp'' && github.event_name != ''pull_request'' }}'