Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow to publish a release #228

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Conversation

OptimumCode
Copy link
Collaborator

@OptimumCode OptimumCode commented Aug 20, 2024

Part of #94

The workflow uses nexus-actions to manage the staging repository. The publication was updated to use the new URL for deployment when a staging repository ID is available.

The following secrets should be added to the project:

@aSemy @krzema12 Could you please take a look at the changes when you have time? Unfortunately, I don't have an OSS account (only OSS1) and cannot test the workflow by myself. But if you have any issues when trying to publish a new release I will be happy to help

@OptimumCode OptimumCode requested review from aSemy and krzema12 August 20, 2024 13:37
@krzema12
Copy link
Owner

Ack, thank you 🙇 In my queue.

aSemy
aSemy previously approved these changes Aug 21, 2024
Copy link
Collaborator

@aSemy aSemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible, thanks!

.github/workflows/release.main.kts Show resolved Hide resolved
.github/workflows/release.main.kts Outdated Show resolved Hide resolved
.github/workflows/release.main.kts Show resolved Hide resolved
.github/workflows/release.main.kts Outdated Show resolved Hide resolved
.github/workflows/release.main.kts Show resolved Hide resolved
@krzema12
Copy link
Owner

Great job, thanks :) I'll configure all the secrets within a day or two, and give it a spin to publish some dummy patch version.

@krzema12
Copy link
Owner

I see that the benchmarks workflow is failing, doesn't seem related to this PR, so I'll take a look as well.

@OptimumCode
Copy link
Collaborator Author

I see that the benchmarks workflow is failing, doesn't seem related to this PR, so I'll take a look as well.

It cannot import the action to validate the Gradle wrapper. It only finds the class with _Untyped suffix.

@krzema12
Copy link
Owner

I see that the benchmarks workflow is failing, doesn't seem related to this PR, so I'll take a look as well.

It cannot import the action to validate the Gradle wrapper. It only finds the class with _Untyped suffix.

Ah ok, so this breaking change is by design: https://kotlinlang.slack.com/archives/C02UUATR7RC/p1723929533809109
I'll take care of it.

@krzema12 krzema12 merged commit 3487c55 into main Aug 21, 2024
10 checks passed
@krzema12 krzema12 deleted the feat/94-release-workflow branch August 21, 2024 10:40
@krzema12
Copy link
Owner

Thanks @OptimumCode, merging so that the workflow appears in the list of workflows, and I can test it with the secrets set.

@OptimumCode
Copy link
Collaborator Author

Thank you @krzema12. Let me know if you have any issues with the publication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants