Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v6provider/refresh): refreshing missing resources now clears them from state #133

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

jimehk
Copy link
Contributor

@jimehk jimehk commented Jun 20, 2024

The new resources implemented with the Plugin Framework had a bug where they
would not clear our state of resources which no longer exist in the API.

This has now been fixed, so resources deleted outside of Terraform are correctly
detected as missing, yielding a plan to recreate them.

Explicitly testing this behavior seems to be fraught with annoyance and
flickering results, so for now I've left that out.

… from state

The new resources implemented with the Plugin Framework had a bug where
they would not clear our state of resources which no longer exist in the
API.

This has now been fixed, so resources deleted outside of Terraform are
correctly detected as missing, yielding a plan to recreate them.

Explicitly testing this behavior seems to be fraught with annoyance and
flickering results, so for now I've left that out.
@jimehk jimehk requested a review from ikadix June 20, 2024 11:43
Copy link
Collaborator

@ikadix ikadix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimehk jimehk merged commit 0ce024b into main Jun 20, 2024
12 checks passed
@jimehk jimehk deleted the fix-missing-resource-detection branch June 20, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants