fix(v6provider): add plan modifier rules to reduce excessive known after apply issues #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimehk
force-pushed
the
fix-plan-building-issues
branch
from
43ae47c
to
eb9e5a8
Compare
…ter apply issues Fixes load balancer rules being marked as requiring re-creation when any attribute is modified on the associate load balancer. This was happening cause the `id` attribute on the load balancer got marked as "known after apply" whenever there were any changes to the load balancer. This in turn caused any load balancer rules which uses the load balancer ID to be marked as re-create, since any change to the `load_balancer_id` attribute requires the rule to be re-created. We're essentially changing the planning phase so that is copies the value from the current state if not known in the plan. Additionally, the load balancer resource gets a custom plan modifier that correctly handles changes between `virtual_machine_ids`, `virtual_machine_group_ids` and `tag_ids`.
jimehk
force-pushed
the
fix-plan-building-issues
branch
from
eb9e5a8
to
5dc0df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes load balancer rules being marked as requiring re-creation when any attribute is modified on the associate load balancer. This was happening cause the
idattribute on the load balancer got marked as "known after apply" whenever there were any changes to the load balancer. This in turn caused any load balancer rules which uses the load balancer ID to be marked as re-create, since any change to theload_balancer_idattribute requires the rule to be re-created.We're essentially changing the planning phase so that is copies the value from the current state if not known in the plan. Additionally, the load balancer resource gets a custom plan modifier that correctly handles changes between
virtual_machine_ids,virtual_machine_group_idsandtag_ids.