Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binaries shouldn't be checked in (usually); need to gitignore them #2

Closed
4 tasks
timotheecour opened this issue Dec 4, 2018 · 1 comment
Closed
4 tasks

Comments

@timotheecour
Copy link

timotheecour commented Dec 4, 2018

  • git-lfs would probably not be needed if binaries weren't being checked in

  • probably a good idea in case there are large objects to put these in a separate (sub-)module

  • something like this could help to gitignore extension-less binaries:

.gitignore

/*
!*.nim
!.gitignore

only mentioning this cause you brought my attention to your repo in nim-lang/Nim#8554 (comment) (thanks for the link!), so I was trying it out but git clone failed (got the clone to work after brew install git-lfs)

@timotheecour timotheecour changed the title binaries shouldn't be checked in (usually); binaries shouldn't be checked in (usually); need to gitignore them Dec 4, 2018
@krux02
Copy link
Owner

krux02 commented Sep 23, 2020

I ditched git-lfs for now, so that people can clone the project again. That experience was painful. Binaries are now just part of the repository, but I try to keep them small. I won't add large assets to the project.

@krux02 krux02 closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants