Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Button): add loading state #990

Merged
merged 3 commits into from
Sep 13, 2024
Merged

feat(Button): add loading state #990

merged 3 commits into from
Sep 13, 2024

Conversation

LarryMatte
Copy link
Contributor

@LarryMatte LarryMatte commented Sep 10, 2024

DS-1227

J'ai dû modifier le spinner pour que les dimensions fonctionnent bien une fois utilisé dans le bouton. Pour certaines raisons, le svg ne prenait pas la pleine largeur et hauteur de son container.

Ajout d'un état "loading".

  • Le composant spinner est à la gauche du label.
  • le label change lorsque le bouton tombe en état de loading.
  • L'utilisateur peut changer le label par défaut de l'état loading.

Mise à jour de la documentation

@LarryMatte LarryMatte requested a review from a team as a code owner September 10, 2024 20:36
Copy link

Storybook for this build: https://ds.equisoft.io/pr-990/

Copy link

Webapp for this build: https://ds.equisoft.io/pr-990/webapp/

Copy link
Contributor

@pylafleur pylafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une petite remarque mais très bon à part ça!

packages/react/src/components/buttons/button.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@pylafleur pylafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LarryMatte LarryMatte merged commit 851ac49 into master Sep 13, 2024
22 checks passed
@LarryMatte LarryMatte deleted the dev/DS-1227 branch September 13, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants