Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp, users): adds delete action #968

Merged
merged 2 commits into from
Aug 19, 2024
Merged

feat(webapp, users): adds delete action #968

merged 2 commits into from
Aug 19, 2024

Conversation

hebernardEquisoft
Copy link
Contributor

@hebernardEquisoft hebernardEquisoft commented Aug 9, 2024

DS-1131

Description

Ici on vient ajouter la data table d'utilisateurs

*Problème détecté: le focus sur les headers des columns lors d'une suppression ne se redirige pas sur le nom/lien du user de la row qui précédait celle supprimée.

Tests fonctionnels

  • Valider le bon fonctionnement de la suppression
  • Valider le bon fonctionnement dans différents navigateurs web (Chrome, Safari)
  • Valider l'ordonnancement des tabulations
  • Valider le bon fonctionnement de nos composantes design system.

Copy link

github-actions bot commented Aug 9, 2024

Storybook for this build: https://ds.equisoft.io/pr-968/

Copy link

github-actions bot commented Aug 9, 2024

Webapp for this build: https://ds.equisoft.io/pr-968/webapp/

@mmorin-equisoft mmorin-equisoft self-assigned this Aug 9, 2024
id: 'actions',
headerAriaLabel: 'actions',
id: 'action-delete',
headerAriaLabel: 'delete',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne crois pas que headerArialLabel sert à quelque chose. Je n'arrive pas a le visualiser dans le UI. De plus, il n'y a pas de header techniquement. 🤔

@LarryMatte LarryMatte merged commit 9566b3f into master Aug 19, 2024
23 checks passed
@LarryMatte LarryMatte deleted the dev/DS-1131 branch August 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants