-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Combobox): restrict custom values #771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylafleur
force-pushed
the
dev/DS-679
branch
2 times, most recently
from
March 18, 2024 19:28
95edad8
to
b14314e
Compare
Storybook for this build: https://ds.equisoft.io/pr-771/ |
meriouma
reviewed
Apr 2, 2024
savutsang
reviewed
Apr 2, 2024
savutsang
approved these changes
Apr 4, 2024
meriouma
approved these changes
Apr 9, 2024
mmorin-equisoft
pushed a commit
that referenced
this pull request
Apr 17, 2024
pylafleur
added a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS-679
Dans le combobox, les comportements suivants ont été ajoutés:
allowCustomValues
disableListFiltering
. Cette possibilité était nécessaire si la liste des options est filtrée à l'extérieur du componentisLoading
place le component dans un état de chargement (utile lorsque les options récupérées du serveur)Une story a été ajoutée qui reproduit le use-case de chargement des données async, qui se rapproche probablement de l'usage demandé par /plan