-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ProgressTracker)!: non linear and clickable #726
Conversation
Storybook for this build: https://ds.equisoft.io/pr-726/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comme discuté tantôt, il reste aussi la question de la zone cliquable et du curseur pointer.
packages/react/src/components/progress-tracker/progress-tracker.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/progress-tracker/progress-tracker.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/progress-tracker/progress-tracker.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/progress-tracker/progress-tracker.tsx
Outdated
Show resolved
Hide resolved
J'ai limite le zone clickable au contenu. J'imagine le cursor pointer c'est par rapport a la zone aussi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quelques commentaires ici et là
packages/react/src/components/progress-tracker/progress-tracker.tsx
Outdated
Show resolved
Hide resolved
J'ai soulevé 2 trucs:
À part ça tout est beau pour moi! |
87402f2
to
e240c42
Compare
e240c42
to
52feda9
Compare
J'ai fixe les font et couleur. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good en ce qui me concerne
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Petits détails, sinon LGTM.
BREAKING CHANGES
Progress
renamed toProgressTracker
.label
is now required on every step item.https://equisoft.atlassian.net/browse/DS-735
https://www.notion.so/equisoft/Progress-Tracker-9d6af548431144e8908970ff4602f851