Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProgressTracker)!: non linear and clickable #726

Merged
merged 11 commits into from
Feb 21, 2024

Conversation

savutsang
Copy link
Contributor

@savutsang savutsang commented Feb 9, 2024

  • Updated UI per figma
  • Navigable with onclick or href
  • Non linear progression
  • Show incomplete icon for uncompleted steps

BREAKING CHANGES

  • Component Progress renamed to ProgressTracker.
  • label is now required on every step item.

https://equisoft.atlassian.net/browse/DS-735
https://www.notion.so/equisoft/Progress-Tracker-9d6af548431144e8908970ff4602f851

@savutsang savutsang requested a review from a team as a code owner February 9, 2024 19:34
Copy link

github-actions bot commented Feb 9, 2024

Storybook for this build: https://ds.equisoft.io/pr-726/

Copy link
Contributor

@meriouma meriouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comme discuté tantôt, il reste aussi la question de la zone cliquable et du curseur pointer.

@savutsang savutsang changed the title feat(ProgressTracker): non linear and clickable feat(ProgressTracker)!: non linear and clickable Feb 14, 2024
@savutsang
Copy link
Contributor Author

savutsang commented Feb 15, 2024

Comme discuté tantôt, il reste aussi la question de la zone cliquable et du curseur pointer.

J'ai limite le zone clickable au contenu. J'imagine le cursor pointer c'est par rapport a la zone aussi.

@meriouma meriouma requested a review from LarryMatte February 15, 2024 18:33
@savutsang savutsang enabled auto-merge (squash) February 15, 2024 18:45
Copy link
Contributor

@LarryMatte LarryMatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quelques commentaires ici et là

@savutsang savutsang disabled auto-merge February 15, 2024 19:43
@maboilard
Copy link

maboilard commented Feb 16, 2024

J'ai soulevé 2 trucs:

  • Dans le visuel de progress-tracker-step-completed, le style de texte pour le numéro devrait être --font-semi-bold
  • Sinon la couleur de backround de progress-tracker-step-completed ainsi que la couleur de border de progress-tracker-step-current (en plus du bridge) ne sont pas de la même couleur que dans Figma. La couleur dans Figma est #006296

À part ça tout est beau pour moi!

@savutsang savutsang force-pushed the DS-735-progress-tracker branch 2 times, most recently from 87402f2 to e240c42 Compare February 16, 2024 17:29
@savutsang
Copy link
Contributor Author

savutsang commented Feb 16, 2024

  • Dans le visuel de progress-tracker-step-completed, le style de texte pour le numéro devrait être --font-semi-bold
  • Sinon la couleur de backround de progress-tracker-step-completed ainsi que la couleur de border de progress-tracker-step-current (en plus du bridge) ne sont pas de la même couleur que dans Figma. La couleur dans Figma est #006296

J'ai fixe les font et couleur.

LarryMatte
LarryMatte previously approved these changes Feb 16, 2024
Copy link
Contributor

@LarryMatte LarryMatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good en ce qui me concerne

@savutsang savutsang enabled auto-merge (squash) February 16, 2024 19:02
Copy link
Contributor

@meriouma meriouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petits détails, sinon LGTM.

@savutsang savutsang merged commit 18563d4 into master Feb 21, 2024
20 checks passed
@savutsang savutsang deleted the DS-735-progress-tracker branch February 21, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants