Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust toggle-button min-height for accessibility when zooming #222

Merged
merged 4 commits into from
Mar 5, 2021
Merged

fix: Adjust toggle-button min-height for accessibility when zooming #222

merged 4 commits into from
Mar 5, 2021

Conversation

mclaberge
Copy link
Contributor

PR Description

JIRA

GitHub issues resolved by PR

...

Bug fix checklist

  • Units tests have been adjusted to account for bug.
  • The fix has been tested in multiple Storybook stories.
  • The CircleCI build is successful.

New component checklist

  • The new component and its tests are in the same component folder.
  • The component is unit tested and/or snapshot tested.
  • All of the relevant Storybook stories have been added to the storybook package.
  • There are no linting errors or warnings in the modified/new code.
  • The CircleCI build is successful.

@mclaberge mclaberge marked this pull request as ready for review March 5, 2021 16:20
@mclaberge mclaberge changed the title Dev/ds 69 fix: Adjust min-height for accessibility when zooming Mar 5, 2021
@mclaberge mclaberge changed the title fix: Adjust min-height for accessibility when zooming fix: Adjust toggle-button min-height for accessibility when zooming Mar 5, 2021
@mclaberge mclaberge requested a review from a team March 5, 2021 16:24
alexishinse
alexishinse approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@alexishinse alexishinse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je pense qu'on pourrait regrouper ces 4 commits en 1

@mclaberge mclaberge merged commit c77d44b into master Mar 5, 2021
@mclaberge mclaberge deleted the dev/DS-69 branch March 5, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexishinse alexishinse alexishinse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mclaberge @alexishinse