fix(Listbox): add bgcolor to selected indicator #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryMatte
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Storybook for this build: https://ds.equisoft.io/pr-1033/ |
LarryMatte
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Webapp for this build: https://ds.equisoft.io/pr-1033/webapp/ |
maboilard
previously approved these changes
Nov 29, 2024
meriouma
reviewed
Dec 4, 2024
| @@ -179,6 +179,7 @@ const ListItem = styled.li<ListItemProps>` | |||
|
|
|||
| ${({ $selected, $multiselect }) => (!$multiselect && $selected && css` | |||
| &::before { | |||
| background-color: ${({ theme }) => theme.component['listbox-item-indicator-selected-background-color']}; | |||
There was a problem hiding this comment.
Je pense que le nom de token est pas bon. Ça devrait peut-être être juste listbox-item-selected-indicator-color ou listbox-item-indicator-selected-color. Le terme background-color est trop lié à comment c'est implémenté et non ce que ça représente je crois.
There was a problem hiding this comment.
@maboilard Voir le commentaire de Max
There was a problem hiding this comment.
Pas de problème pour moi. Si c'est plus logique comme ça, allons-y avec listbox-item-indicator-selected-color
There was a problem hiding this comment.
@maboilard parfait assures-toi de faire la modification dans figma
LarryMatte
temporarily deployed
to
github-pages
GitHub Actions
Inactive
LarryMatte
temporarily deployed
to
github-pages
GitHub Actions
Inactive
meriouma
approved these changes
Dec 6, 2024
pylafleur
approved these changes
Dec 6, 2024
LarryMatte
temporarily deployed
to
github-pages
GitHub Actions
Inactive
LarryMatte
temporarily deployed
to
github-pages
GitHub Actions
Inactive
LarryMatte
force-pushed
the
dev/DS-1268
branch
from
cef2d04 to
c647bff
Compare
LarryMatte
temporarily deployed
to
github-pages
GitHub Actions
Inactive
LarryMatte
temporarily deployed
to
github-pages
GitHub Actions
Inactive
LarryMatte
added a commit
that referenced
this pull request
Jan 9, 2025
* fix(Listbox): add bgcolor to selected indicator * fix(Listbox): fix lint * fix(Listbox): fix token name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS-1268
Il manquait la couleur background sur l'indicateur de l'option sélectionnée.
Avant:
Après:
