Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MoneyInput,NumericInput,TextInput): expose CSS class to allow styling elements #1027

Merged
merged 2 commits into from
Nov 14, 2024
Merged

feat(MoneyInput,NumericInput,TextInput): expose CSS class to allow styling elements #1027

merged 2 commits into from
Nov 14, 2024

Conversation

meriouma
Copy link
Contributor

@meriouma meriouma commented Nov 5, 2024

Permet de contrôler la largeur de l'input en faisant

import { TextInput, textInputClasses } from '@equisoft/design-elements-react';

const SomeInput = styled(TextInput)`
    .${textInputClasses.control} {
        width: 80px;
    }
`;

J'ai aussi ramené le numeric-input pour qu'il utilise le TextInput, et enlever un layer de div dans le MoneyInput.

@meriouma meriouma requested a review from a team as a code owner November 5, 2024 00:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Storybook for this build: https://ds.equisoft.io/pr-1027/

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Webapp for this build: https://ds.equisoft.io/pr-1027/webapp/

meriouma
meriouma commented Nov 5, 2024
View reviewed changes
packages/react/src/utils/generate-component-classes.ts
@@ -0,0 +1,12 @@
const DS_CLASS_PREFIX = 'eds-';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai mis eds pour Equisoft Design System mais je suis ouvert aux propositions🤷‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un jour faudrait qu'on se trouve un p'tit nom plutôt que "DS"...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un jour faudrait qu'on se trouve un p'tit nom plutôt que "DS"...

soon to come

@LarryMatte
Copy link
Contributor

@pylafleur @savutsang, à reviewer quand vous aurez 2min.

pylafleur
pylafleur approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@pylafleur pylafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meriouma meriouma merged commit e38c8f6 into master Nov 14, 2024
22 checks passed
@meriouma meriouma deleted the dev/DS-1262/DS-1263 branch November 14, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarryMatte LarryMatte LarryMatte left review comments

@pylafleur pylafleur pylafleur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meriouma @LarryMatte @pylafleur