Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): prevent input compression with long text by adding flex-shrink #1021

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

LarryMatte
Copy link
Contributor

https://equisoft.atlassian.net/browse/DS-1261

Lorsque le label du checkbox est trop long et tombait sur 2 lignes, l'input était compressé.

@LarryMatte LarryMatte requested a review from a team as a code owner November 1, 2024 14:33
Copy link

github-actions bot commented Nov 1, 2024

Storybook for this build: https://ds.equisoft.io/pr-1021/

Copy link

github-actions bot commented Nov 1, 2024

Webapp for this build: https://ds.equisoft.io/pr-1021/webapp/

Copy link
Contributor

@meriouma meriouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Petite question, est-ce qu'on voulait que la checkbox soit alignée verticalement en haut ou au milieu quand le label est sur plusieurs lignes? Pour l'instant ça a l'air d'être en haut.

@LarryMatte
Copy link
Contributor Author

LGTM. Petite question, est-ce qu'on voulait que la checkbox soit alignée verticalement en haut ou au milieu quand le label est sur plusieurs lignes? Pour l'instant ça a l'air d'être en haut.

oui ca cest good

@LarryMatte LarryMatte merged commit 2b66bae into master Nov 5, 2024
22 checks passed
@LarryMatte LarryMatte deleted the dev/DS-1261 branch November 5, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants