fix(Theme): resolve alias tokens to ref token values #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook for this build: https://ds.equisoft.io/pr-1013/ |
|
Webapp for this build: https://ds.equisoft.io/pr-1013/webapp/ |
meriouma
commented
Oct 22, 2024
| } | ||
|
|
||
| if (isAliasToken(token)) { | ||
| const aliasToken = customizedTheme.alias[token]; | ||
| const aliasToken = resolvedTheme.alias[token]; |
There was a problem hiding this comment.
J'ai changé un peu l'algo pour pas toujours resolve les tokens et utiliser ceux qui ont déjà été resolved à la place. Ça va raccourcir un peu le nombre de boucles quand des alias réfèrent d'autres alias.
hebernardEquisoft
approved these changes
Oct 25, 2024
pylafleur
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Les alias tokens n'étaient pas utilisables en dehors du DS, alors ça rendait l'utilisation des couleurs difficile dans les apps. En gros le snapshot montre les changements sur les alias tokens en output.