Merge pull request #535 from kristerkari/bugfix/dimension-no-non-nume…

…ric-values-unitless-interpolation dimension-no-non-numeric-values: fix error thrown with unitless interpolation
stylelint-scss · Jul 18, 2021 · a4ab191 · a4ab191
2 parents 0ed236a + c3fffd9
commit a4ab191
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/rules/dimension-no-non-numeric-values/__tests__/index.js b/src/rules/dimension-no-non-numeric-values/__tests__/index.js
@@ -24,6 +24,13 @@ testRule(rule, {
       code: `$pad: "2";
       $string: "#{$pad}px";`,
       description: "does not report lint when string is quoted"
+    },
+    {
+      code: `
+      @include media-breakpoint-up($grid-gutter-breakpoint) {
+        --#{$variable-prefix}gutter-x: #{$gutter * 2};
+      }`,
+      description: "ignores interpolation without a unit"
     }
   ]),
   reject: loopOverUnits({

diff --git a/src/rules/dimension-no-non-numeric-values/index.js b/src/rules/dimension-no-non-numeric-values/index.js
@@ -93,6 +93,11 @@ export default function rule(primary) {
 
         const regex = new RegExp(`#{[$a-z_0-9 +-]*}(${units.join("|")});?`);
         const matchUnit = decl.value.match(regex);
+
+        if (!matchUnit) {
+          return;
+        }
+
         const unit = matchUnit[1];
         const offset = decl.value.indexOf(unit);