-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend native promises? #805
Comments
It seems like it would be at least worth mentioning native promises in the README. Personally I wouldn't recommend them over Q though. In my apps I do |
@jbunton-atlassian Node has way better stack traces with async stack traces support in debugging and better unhandled rejection detection, and |
I'm not a fan of promisifyAll, I've seen it break with a semver compatible upgrade when libraries add new methods. But of course you're right that I'm interested in getting better stack traces for the builtin Node promises. Is this some hidden Node flag, or an npm module that does some magic? In particular can they pass this test ? |
Given native promises have been up since 2013 I think it would make sense to recommend them over Q with migration notes.
I wouldn't mind writing a package similar to https://github.com/benjamingr/bluebird-api/ for Q if you'd like?
The text was updated successfully, but these errors were encountered: