From 3795b403b9ac038b2e6df54eb7c21e9983b21b8d Mon Sep 17 00:00:00 2001 From: Mikhail Krinkin Date: Fri, 3 Jan 2025 13:06:08 +0000 Subject: [PATCH] Fix librdkafka Envoy dependency builds New version of LLD coming with llvm-18 generates erros when building librdkafka dependency on Envoy (see https://github.com/confluentinc/librdkafka/issues/4593). While there is an upstream PR fixing the issue, it has not been merged and even when it will be merged, Envoy release v1.32 will still be stuck with an old version without this fix. I'm working around this with a patch to Envoy codebase by disabling the use of linker scripts in librdkafka builds alltogether, and as a consequence disabling the issues that come from the symbols defined in the linker script only. Signed-off-by: Mikhail Krinkin --- bazel/foreign_cc/BUILD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bazel/foreign_cc/BUILD b/bazel/foreign_cc/BUILD index 60271a492559..cf4054d758c1 100644 --- a/bazel/foreign_cc/BUILD +++ b/bazel/foreign_cc/BUILD @@ -96,7 +96,7 @@ configure_make( ], tags = ["skip_on_windows"], targets = [ - "ARFLAGS='' libs install-subdirs", + "ARFLAGS='' WITH_LDS='n' libs install-subdirs", ], deps = [":lz4"], alwayslink = True,