Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confocal Ovules ds2x and ds3x are the same #138

Closed
lorenzocerrone opened this issue Apr 5, 2023 · 2 comments · Fixed by #139
Closed

Confocal Ovules ds2x and ds3x are the same #138

lorenzocerrone opened this issue Apr 5, 2023 · 2 comments · Fixed by #139
Assignees

Comments

@lorenzocerrone
Copy link
Collaborator

lorenzocerrone commented Apr 5, 2023

Hey Adrian @wolny,

I have noticed something weird in the new plantseg models. The generic confocal, ds2x ovules and the ds3x ovules have all the same weights (see screenshot)
Screenshot from 2023-04-05 16-20-39

Also I just noticed that the generic confocal has not the same weights as the old version (the one in the own cloud).

I think there must have been some error in moving them to zenodo.
Could you please look at it?

@wolny
Copy link
Collaborator

wolny commented Apr 6, 2023

hey @lorenzocerrone, thanks for looking into this! generic confocal is just an alias for ds2x ovules, so that's expected but ds3x ovules looks like a bug. I'll compare with the old weights we still have on ownCloud

@wolny wolny self-assigned this Apr 6, 2023
@wolny
Copy link
Collaborator

wolny commented Apr 6, 2023

indeed! I've just checked the weights from owncloud: ds2x ovules had the weights from ds3dx. Really nice that you've checked that, otherwise the performance would silently be lower than before most likely 🙌.
I'll re-upload the correct weights to zenodo and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants