Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.1.0 #93

Closed
krakjoe opened this issue Jan 2, 2019 · 9 comments
Closed

Release 5.1.0 #93

krakjoe opened this issue Jan 2, 2019 · 9 comments
Assignees

Comments

@krakjoe
Copy link
Owner

krakjoe commented Jan 2, 2019

Can we get a release tagged please remi, I've updated package.xml although you may want to double check it ... I think we're good to go ...

Here's a changelog:

@krakjoe krakjoe changed the title Release Release 5.1.0 Jan 2, 2019
@remicollet
Copy link
Collaborator

remicollet commented Jan 2, 2019

@krakjoe can you please check why tests/040.phpt is failing with 7.1 ?

001+ Notice: Undefined variable: class in /work/GIT/uopz/tests/040.php on line 2

@krakjoe
Copy link
Owner Author

krakjoe commented Jan 2, 2019

oh we can suppress that safely, I'm testing for the exception only ...

@remicollet
Copy link
Collaborator

@krakjoe test shlould be fixed by 2984098

@krakjoe
Copy link
Owner Author

krakjoe commented Jan 2, 2019

specifically though we're testing IS_UNDEF, and that's IS_NULL now ...

Try this:

diff --git a/tests/040.phpt b/tests/040.phpt
index 2f7a381..3f6dc0b 100644
--- a/tests/040.phpt
+++ b/tests/040.phpt
@@ -2,9 +2,12 @@
 fetch class undef class no mock
 --SKIPIF--
 <?php include("skipif.inc"); ?>
+--INI--
+error_reporting=E_ALL & ~E_WARNING
 --FILE--
 <?php
 var_dump($class::qux());
+?>
 --EXPECTF--
 Fatal error: Uncaught Error: Class name must be a valid object or a string in %s:2
 Stack trace:

@remicollet
Copy link
Collaborator

OK, done in 6a9ad9d

@remicollet
Copy link
Collaborator

@krakjoe obviously missing in changelog ;)

  • Fix PHP 7.3 compatibility

@remicollet
Copy link
Collaborator

@krakjoe see 760a7a9 and df24a77

Going to run test build, and then run the release.

@remicollet
Copy link
Collaborator

@krakjoe
Copy link
Owner Author

krakjoe commented Jan 2, 2019

Great stuff @remicollet, ta very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants