Add input validation on the values updated in the web interface. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure to do this risks crashing the code on the int() or float() casts. Its also possible for an invalid value to be written which if the user saves the configuration which will prevent the web interface program from starting again so the invalid configuration variable can't be fixed with the GUI. How to reproduce: 1) Start with a working configuration 2) Erase the contents of the ant_spacing_meters field or just enter a non-number 3) Push save configuration The only way to recover is to use shell access and fix or replace the krakensdr_doa/_ui/settings.json file.
|
I just updated my Kraken to V1.8 and it seems much more stable, even without my changes. I believe the image I used back in January looks like its based on V1.7 or thereabouts. Are there changes in V1.8 that would explain it tolerating invalid input better? |
added 2 commits
April 2, 2024 11:55
|
Thanks for the PR. n 1.8 a few sanitization checks were added on the UI side, but it can't stop an empty null value that has been entered. Your PR appears to fix that condition so I've merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure to do this risks crashing the code on the int() or float() casts. Its also possible for an invalid value to be written which if the user saves the configuration which will prevent the web interface program from starting again so the invalid configuration variable can't be fixed with the GUI.
How to reproduce:
The only way to recover is to use shell access and fix or replace the krakensdr_doa/_ui/settings.json file.