Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to grumbler scripts 8 #414

Merged
merged 2 commits into from
Nov 17, 2022
Merged

feat: upgrade to grumbler scripts 8 #414

merged 2 commits into from
Nov 17, 2022

Conversation

dtjones404
Copy link
Contributor

DTPPSDK-957

  • Migrated to grumbler scripts v8.
  • Added flow-typed, jest, and cross-env as explicit dev-dependencies.
  • Added eslint override for test directory and removed /test/eslintrc
  • Added declaration for __DEBUG__ to resolve flow error

@dtjones404 dtjones404 requested a review from a team as a code owner November 10, 2022 19:55
{
files: ["test/**/*"],
rules: {
"max-lines": "off",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fuckin HATE this rule

Copy link
Contributor

@westeezy westeezy Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its relaxed in v8!

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Base: 95.63% // Head: 95.63% // No change to project coverage 👍

Coverage data is based on head (908125d) compared to base (123c702).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files          18       18           
  Lines        1213     1213           
=======================================
  Hits         1160     1160           
  Misses         53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@westeezy westeezy merged commit b857e89 into main Nov 17, 2022
@westeezy westeezy deleted the grumbler-scripts-8 branch November 17, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants