Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency s2 should be replaced with BabelGrid successor #134

Open
Sigmanificient opened this issue Jul 21, 2024 · 2 comments
Open

Dependency s2 should be replaced with BabelGrid successor #134

Sigmanificient opened this issue Jul 21, 2024 · 2 comments

Comments

@Sigmanificient
Copy link

Sigmanificient commented Jul 21, 2024

Hi, I am working on porting this project to nixpkgs (the nix package manager repository), in NixOS/nixpkgs#328819, as it what requested by an user.

While writing a derivation (package), we create also tends to initialize all the missing dependencies along with it, from source (whenever possible). During this process, I noticed an warning on the s2s repository README:

⚠️ Project was merged to BabelGrid ⚠️

s2's dependency, s2sphere was also archived 9 months ago, meaning it will not receive any future updates.

This issue is here to makes sure that you are aware of this minor dependency issue.
I believe you may consider switching to the newer BabelGrid which conveniently supports s2 and h3.

Thanks for your interest

@RaczeQ
Copy link
Collaborator

RaczeQ commented Jul 24, 2024

Hello @Sigmanificient
Thank you for porting the library to the nixpkgs project and pointing out the potential issues regarding S2 dependency.

I tried to use the BabelGrid package, but I encountered few problems with integration:

  1. I can't add it to my stack, because of the H3 dependency version clash (fixed 3.6.6 in BabelGrid vs minimal 4.0.0b in another dependency in my project)
  2. s2sphere is also a dependency in the BabelGrid project, so switching to it won't resolve this problem. Although S2 package is archived and merged into BabelGrid, since it already exists on PyPI, it won't move anywhere and I think that there is no potential update to the S2 grid system.

I might look into alternatives that don't use s2sphere package, but unfortunately it won't be high on my priorities list in the near future.

@Sigmanificient
Copy link
Author

Thanks for the reply! I hope you will be able to find an alternative for this dependency.

Thankfully it is only optional, and it will not cause issue in nixpkgs's side 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants